Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pipeline indentation #317

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Correct pipeline indentation #317

merged 1 commit into from
Apr 3, 2016

Conversation

tonini
Copy link
Contributor

@tonini tonini commented Apr 3, 2016

fixes #243

@whatyouhide
Copy link

Awesome 👏!

@gausby
Copy link
Contributor

gausby commented Apr 3, 2016

I appreciate this, thanks!

@lexmag
Copy link

lexmag commented Apr 3, 2016

@tonini tonini merged commit c5d1cba into master Apr 3, 2016
@tonini
Copy link
Contributor Author

tonini commented Apr 3, 2016

Thanks I appreciate the patience you guys had 😄

@tonini tonini deleted the correct-pipeline-indenation branch April 3, 2016 10:25
@gausby
Copy link
Contributor

gausby commented Apr 3, 2016

Hmm, I don't think this is solved completely. Just pulled the master of emacs-elixir and got this behavior:

I expected this:

defmodule Foo do
  def bar do
    baz =
      [1,2,3,4,5,6,7,8,9]
      |> Enum.reverse
      |> Enum.filter(&(&1 > 5))
  end
end

I got this:

defmodule Foo do
  def bar do
    baz =
      [1,2,3,4,5,6,7,8,9]
          |> Enum.reverse
              |> Enum.filter(&(&1 > 5))
  end
end

Is it just me?

@tonini
Copy link
Contributor Author

tonini commented Apr 3, 2016

thanks @gausby!

I'm on it

@whatyouhide
Copy link

Reproduced the same behaviour as @gausby.

J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
* Try not setting RUN_DIALYZER for 1.10.3

* Remove other references to RUN_DIALYZER
@mreyk
Copy link

mreyk commented Apr 29, 2021

Hi everyone, I just wanted to know if this is solved or not. A similar issue happens with the case do. Elixir indentation should be this one:

variable
|> case do
  nil ->
    :noop
  _ ->
    :ok
end

But the elixir-mode does this, it places four spaces:

variable
|> case do
    nil ->
      :noop
    _ ->
      :ok
end

@axelson
Copy link
Contributor

axelson commented Apr 30, 2021

@mreyk can you file that as a separate issue?

@mreyk
Copy link

mreyk commented May 11, 2021

@axelson , sure. I have created a new issue in #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct indentation for pipe operator
6 participants